I want to thank @ground024 for an Eloquence pop report, but in reproducing it I discovered something I really don't like. We're going to have to raise that buffer in 16 KHZ mode a little bit, and responsiveness will be effected. ...This is when I remind everyone that in 16 K mode, we are asking the synth to do things it was never designed to do.
@amir No. That buffer is perfectly fine, probably Eloquence's Golden ratio when operating at normal spec. The addon can and will treat these as separate implementations. @ground024
@amir I should say that I'll only raise the buffer commensurate with what it takes to stop it from clicking and popping. The hope is that you will experience something more like the keypress delay you'd get in beta 4, rather than something significantly worse. However, we do have to make it so that an average sentence won't make the thing pop more than its 11 KHZ version, otherwise it's irresponsible for me to call it stable. @ground024
@nick@ground024 BTW I also suggest raising NVDA's compatibility to something like NVDA 2099 to match what @fastfinge has done. This will cover NVDA 2027 and beyond without that nagging compatibility issue.
@amir Will take under advisement. I didn't because I'd planned to manually make absolutely certain this worked once 2027's addon standard went final, so honestly, it's immaterial to me. @ground024@fastfinge
@nick@ground024@amir The primary reason I did it, actually, is because I didn't want someone submitting it to the store. While it's...probably legal, I don't want it in the store. Having an invalid NVDA version means it will fail the automated tests if anyone tries to submit it to them."
By the way dude, thanks for being so cool about this entire thing since I started. This entire damn project was born out of my being impatient and a miscommunication, but you've been great even so. @ground024@amir
@nick@ground024@amir I mean honestly, forks are the entire point of open source. I frequently fork things if I don't like the direction they're going or want something the maintainer won't/can't/doesn't have the time to do. Usually I'm the only one who cares, because I was the only one who needed my changes. But I'm not going to be annoyed if someone else forks my stuff. The point of releasing anything at all is for it to be useful. If you fork and it's useful to a different group of users that I can't, or don't want, to serve, that's a good thing. And I feel like your fork gave you and your users a lot of experience about what you want, how you want it, and why you want it. If you later send a PR to me, I get to benifit from all that learning, while not having to moderate all the discussion or approve all the code myself. As far as I'm concerned this has been open source working as intended. And for something like eloquence...I couldn't exactly list it on my resume. Although you credited me anyway, if that was important to me for some reason.
@nick@ground024@amir You got all the users who really really wanted resampling. I get it. But as a non-audio guy it's just work I can't do, or test, or make smart decisions about, written in code I couldn't read. So I'd been refusing them for months. Now you know what the smart decisions are, and everyone knows you don't release code until you're sure it works. So if you decide to bring it to main everyone can be sure you have the expertise and experience needed to make smart decisions about it, both from your fork, and your background in radio.
@fastfinge I'm glad you said that here. Because the rest of you, that's what's happening when OpenEVV turns into a synth that doesn't have ViaVoice's regressions/Speaks Finnish - My Finish friends would roast me on a spit if I abandoned RS before it spoke their language. Once EVV becomes Golden, this addon dies, but we'll be carrying at least some of the presence features, subject to my judgment on what actually works with OpenEVV. @ground024@amir
@nick RS seemed to handle this test phrase better than others. Had I been reading it with RS I wouldn't have even made the post. Went back and listened with all samplerates presents smooth and still nothing worth commenting on with RS. Maybe you can hear the library glitching out a bit but eloquence gonna be eloquence. Wish you could have RS and e64 installed at the same time but this has probably been debated plenty as well.@fastfinge@interfree.ca @amir RS
@amir test phrase with the pop around was impressed. I once had such bad piles that when one ruptured I had to use one of my wife's tampons to staunch the flow. Tbf the doc at A&E was impressed with my ingenuity. @nick@fastfinge
@fastfinge That would be halarious. Do you plan to make a version of your addon with openev only for testers? I am hoping to move full time and find a way to provide better debug info when the nvda process restarts. your code is the only one for openev that does the shortened pause. @nick@amir
@amir I have the latest version. there is checkbox but I am unsure what engine is running when, how the loading and unloading is done. Need to check openve box, restart nvda, and check taskmon to make sure the host isn't running. When does the engine change, check box, ok button, it doesn't seem to unload the host after I change so it's unclear unless you have some special speech test case queued up. @fastfinge@nick
@ground024@nick@amir You have to check the box and restart NVDA. It won't switch until you restart. It also won't switch if you're using a language openevv doesn't support.
