User avatar
Amir @amir@dragonscave.space
2w
@fastfinge The openevv project now has a PR to take care of the sample rate issues. Could you please incorporate it into Eloquence 64's openevv section for testing?
Add a wideband voice, and do everything above 11,025 in whole numbers:
github.com/Mudb0y/openevv/actions/runs/37492982819
2
0
0
0
User avatar
🇨🇦Samuel Proulx🇨🇦 @fastfinge@interfree.ca
2w
@amir Is there any reason this has a checkbox? I'm struggling to understand why anyone would set a sample rate above 11025 kHz and want wideband off? I don't even understand why openEVV made this a setting. Is there any reason to not just have it always on?
2
0
0
0
User avatar
Nick Giannak III @nick@hkc.social
2w
@fastfinge There is one, I repeat, one, edge case where you might do this - You have a DAC that has terrible resampling and you want the 11 KHZ sound to not alias. Some integrated systems qualify. @amir
1
0
0
0
User avatar
Amir @amir@dragonscave.space
2w
@nick @fastfinge Hmm. That's also something to consider.
1
0
0
0
User avatar
🇨🇦Samuel Proulx🇨🇦 @fastfinge@interfree.ca
2w
@amir @nick My worry is that too many checkboxes will confuse 99 percent of users, and then we get to spend the rest of our lives answering questions about why resampling doesn't work, or what that checkbox is for.
1
0
1
0
User avatar
Nick Giannak III @nick@hkc.social
2w
@fastfinge Which is why if I were you, I wouldn't implement it in the Eloquence addon. What lives in EVV upstream doesn't have to live in the addon. @amir
1
0
0
0
User avatar
🇨🇦Samuel Proulx🇨🇦 @fastfinge@interfree.ca
2w
@nick @amir Okay, sounds good. I was just checking to see if there was some reason I should that I hadn't thought of.
1
0
0
0
User avatar
Nick Giannak III @nick@hkc.social
2w
@fastfinge Yeah, your users will never hit this edgecase because we're not using SoundBlaster PCI 64 cards on Windows Melennium. @amir
2
0
1
0
User avatar
🇨🇦Samuel Proulx🇨🇦 @fastfinge@interfree.ca
2w
@nick @amir Okay. I'm in the middle of some work stuff this afternoon, but I'll get to this tomorrow morning, unless one of you gets to it first. When building for any purpose other than release, eloquence_64 already automatically downloads the latest openEVV commit artifact. And the samplerate code is already there. So it's literally just a matter of adding the ECI setting and rebuilding. Then waiting to do an actual release until OpenEVV gets the feature into a release on there end.
0
0
0
0