User avatar
Quin @TheQuinbox@dragonscave.space
6d
If you use your AI to submit a pull request to a repository without actually testing your changes, you are disrespecting the maintainer's time. I've seen this multiple times this weekend alone and it annoys me to no end. Passing unit tests is not a substitute for actually testing the behavior you've changed. If you're changing how a screen reader, add-on, application, etc behaves, you, need, to test it as much as you can. Leaving me to slog through a PR, including testing it myself when you couldn't even be fucked to do that, makes me just not want your contributions. Why should I take your pull request seriously when you didn't take it seriously enough to test it and confirm it fixes what presumably annoyed you into fixing it in the first place?
5
14
1
0
User avatar
🇨🇦Samuel Proulx🇨🇦 @fastfinge@interfree.ca
6d
@TheQuinbox Also, pull requests that include more than one change, and are unclear about what they're trying to fix. These days, I only accept a pull request that marks an existing issue as closed. File the issue first, then open the PR right away, that's fine. But I do! need to see the issue first, for documentation, and so I know both you and I understand what your PR does. Also, there could be a better way to fix your issue. If I refuse your PR, I at least still have the issue.
0
1
2
0